github-actions[bot] commented on PR #5325: URL: https://github.com/apache/solr/pull/5325#issuecomment-6821121947
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: fixed <!-- The change fixes a bug where the `SOLR_PID_DIR` environment variable was ignored on Windows, causing port files to be written to the installation directory instead of the specified location, which contradicts the documentation and breaks `stop --all`/`status` for users who set the variable. --> - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not needed <!-- The Reference Guide already documents that `SOLR_PID_DIR` is used by `status` and recommends setting it; this PR simply makes the Windows script behave as already documented, so no new documentation is required. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is backwards-compatible; the default value for `SOLR_PID_DIR` remains `%SOLR_TIP%\bin`, so behavior is unchanged for users who do not explicitly set the variable. --> - ✅ Tests: not needed <!-- The change is to a Windows batch script (`solr/bin/solr.cmd`), which is developer tooling/CLI infrastructure that is not covered by the standard Java test suite, and the author notes that no automated test harness exists for it yet. --> <!-- Assessed commit 81fd98a7c8e496c5d37bc461bcf16dccd28dc79c --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
