github-actions[bot] commented on PR #5321: URL: https://github.com/apache/solr/pull/5321#issuecomment-6804721053
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: added <!-- The PR introduces a new opt-in syntax for the `fl` parameter (field exclusions like `fl=-title`), which is a new feature requiring user action to use and is documented in the Reference Guide. --> - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): included <!-- The PR adds new syntax to the `fl` request parameter, which is a user-facing API change that must be documented in the Solr Reference Guide. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is additive; it only activates when a leading `-` is used in the `fl` parameter, which was previously parsed as a function or invalid, so existing behavior is unchanged. --> - ✅ Tests: included <!-- The PR modifies the parsing and filtering logic in `SolrReturnFields.java` to support exclusions, which is non-trivial production logic that requires tests to verify correct behavior for various combinations of globs, exclusions, and explicit fields. --> <!-- Assessed commit 35db4554284ca0d2ca37eb78ed4c7c7dee599db2 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
