epugh opened a new pull request, #5319: URL: https://github.com/apache/solr/pull/5319
https://issues.apache.org/jira/browse/SOLR-18553 Surveyed v2 (JAX-RS) APIs for query/path/body param names with underscores. Found one genuine, unjustified inconsistency: `ListCollectionsApi`'s `GET /api/collections?detailed=true` accepted `_route_` as a query param, left over from mirroring the v1 wire format even though this specific param has no v1 equivalent to stay compatible with. Other `v2 API response fields with underscores (`node_name`, `base_url`, `force_set_state`, `recovery_failed`, `solr_home`, `core_root`, `environment_label`, `environment_color`) were checked individually and are intentional — they mirror either literal ZooKeeper `state.json` property names (`Replica.java`'s `NODE_NAME`/`BASE_URL`/`FORCE_SET_STATE` constants) or pre-existing v1 wire formats that predate their JAX-RS migration, so those are out of scope here. This rename is v2-only: - v1 `LIST` calls `ListCollections.listCollections(null, null, null, null, null)` — the route param is always null, never passed through. - v1 `CLUSTERSTATUS` is a fully separate implementation (`new ClusterStatus(zkStateReader, req.getParams())`) that never goes through `ListCollectionsApi`. Also updates the two ref guide spots that documented the old `_route_` name for this endpoint. ## Test plan - [x] `:solr:api:compileJava` / `:solr:core:compileJava` / `:solr:core:compileTestJava` all clean - [x] `ListCollectionsDetailedTest` (7/7), `ListCollectionsDetailedStandaloneTest` (1/1) pass - [x] Confirmed no existing test exercises the old `_route_` param name for this endpoint 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_018RwsEje8u9apx3SRzissZm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
