epugh commented on PR #5201: URL: https://github.com/apache/solr/pull/5201#issuecomment-6778419917
> Hi [@epugh](https://github.com/epugh), > > [P2] Explorer requests do not use the Admin UI’s credentials. [The Scalar initializer](https://github.com/apache/solr/blob/3f9faa9e9861ce28f3ede3f4305bd91b6e297463/solr/webapp/web/libs/scalar/scalar-init.js#L18-L29) runs outside the Admin UI’s request interceptors and does not attach the Basic or JWT credentials stored in session storage. Authenticated API calls may therefore receive a 401 or a separate browser challenge. This was [already raised on the PR](https://github.com/apache/solr/pull/5201#discussion_r4486925599). The author reports a fix, but it is not present at the verified PR head. > > [P2] The explorer has no behavior test. The PR adds infrastructure to serve its generated assets during browser tests, but no test opens the explorer, renders the spec, or sends a request. The author [reports that “Test Request” hangs](https://github.com/apache/solr/pull/5201#discussion_r4520163191); I did not independently reproduce or diagnose it. A focused browser test should cover the packaged assets, production framing policy, a harmless request, and authenticated use. This gap was also [raised on the PR](https://github.com/apache/solr/pull/5201#discussion_r4486925540). > > AI-generated. Hey @nick-boss-tech I'd love you to take a stab at those two P2's... I burned a bunch of tokens + manual work trying to get the Scalar Initilizaer to actually work... What I foudn was that with basic auth, I would just always get the browser popup when I wen to send the request.. maybe due to the iframe? I finally decided I could live with it, but it would be much nicer if it just worked... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
