sarkaramrit1993 commented on PR #4916: URL: https://github.com/apache/solr/pull/4916#issuecomment-6763175194
Thanks Eric. Yes to both. First, a separate JIRA and PR for stable permission ids. Today `index` is list position and [delete renumbers it](https://github.com/apache/solr/blob/acdee50e7b9a1d1418b4145a5396d0f83bc7912a/solr/core/src/java/org/apache/solr/security/AutorizationEditOperation.java#L149-L156), the root of blockers 1 and 2 in [my review](https://github.com/apache/solr/pull/4916#pullrequestreview-5477474529). Ids would be set once and never reused, with `index` still accepted by v1 [`set-permission`](https://github.com/apache/solr/blob/acdee50e7b9a1d1418b4145a5396d0f83bc7912a/solr/core/src/java/org/apache/solr/security/AutorizationEditOperation.java#L55-L120), [`update-permission`](https://github.com/apache/solr/blob/acdee50e7b9a1d1418b4145a5396d0f83bc7912a/solr/core/src/java/org/apache/solr/security/AutorizationEditOperation.java#L121-L141) and [`delete-permission`](https://github.com/apache/solr/blob/acdee50e7b9a1d1418b4145a5396d0f83bc7912a/solr/core/src/java/org/apache/solr/security/AutorizationE ditOperation.java#L142-L162). Small enough for 10x. Then I'll push the rest to your branch, including the 404 for non-Basic schemes from [my last comment](https://github.com/apache/solr/pull/4916#issuecomment-6598128060). I'll also start a Google Doc listing each endpoint and which plugins support it, and link it here. Agreed on Shiro. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
