nick-boss-tech commented on PR #5282: URL: https://github.com/apache/solr/pull/5282#issuecomment-6611035441
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* Thanks, Eric. I followed the approach of keeping the selection until the refreshed lists are ready, and found two related problems: - Responses from an earlier navigation could finish late and replace the current menu. Refresh callbacks now ignore obsolete requests, including after a route change. - Alias overview copied the selection before loading completed and never updated that copy. It now follows the refreshed alias matching its route, including changes to its targets and properties, and clears its details when that alias disappears. The empty-input guard stays in `showCollection`, protecting every call to the handler. A guard at the `ng-change` call site would not fix those shared-state problems. Current collection/alias request failures preserve the previous selection while reporting the error. The changes and regression tests are in [this diff](https://github.com/nick-boss-tech/solr/compare/6ee3c9b6370e6e1e3b4da4afcf968a0806cc747f...200ff5e5c6c214212f72f37485487f3092e05541). <details> <summary>Linux verification at 200ff5e5c6c214212f72f37485487f3092e05541</summary> - JavaScript syntax checks, full `tidy` with no tracked changes, and `:solr:webapp:check -x test` pass on Linux with JDK 21 and Gradle 9.7.0. - `AdminUiMenuRefreshTest` compiles and discovers nine tests, but all nine were skipped because the Selenium group was disabled. This host had no usable Chrome installation, so no browser test executed. - The neighboring browser suites, both comparisons against the original production code, and root `check -x test` have not run. Browser behavior and fail-before results remain unverified. - The upstream [Admin UI Tests run](https://github.com/apache/solr/actions/runs/41680303677) currently reports `action_required`. The tests use controlled callback ordering with the bundled Angular/Chosen implementation. The empty-input test calls the handler directly; it does not establish that deleting a model automatically fires `ng-change` on every page load. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
