github-actions[bot] commented on PR #5313: URL: https://github.com/apache/solr/pull/5313#issuecomment-6720262187
<!-- llm-pr-triage --> **Automated PR triage** (LLM-generated; may be wrong). Checked once, when the PR was opened or marked ready; not updated on later pushes. No clear mismatches in the answered judgements. | | Warranted? | In PR? | Confidence | Why | |---|---|---|---|---| | ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) | — | yes | — | Already present; not judged. | | ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) | fixed | fixed | high | The PR fixes a bug where the default ZooKeeper wait time was incorrectly calculated as 30000 seconds instead of 30 seconds, and restores functionality for the deprecated -DwaitForZk system property. | | ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) | no | no | medium | The change fixes the behavior of the existing `solr.cloud.wait.for.zk.seconds` property to match its documented intent (seconds) and restores a deprecated property; it does not introduce new configuration options or change documented behavior in a way that requires new documentation. | | ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages) | no | no | high | The change restores the intended default behavior (30 seconds) and fixes a deprecated property; it is not a backwards-incompatible change requiring user action. | | ✅ Tests | yes | yes | high | The PR modifies production logic in `NodeConfig.java` and `EnvUtils.java` to fix unit conversion and legacy property mapping, which warrants new or updated tests to verify the correct behavior. | _⚠️ mismatch, ❔ uncertain or unanswered, ✅ agrees. Matching changelog, docs and test files were hidden from the model; the PR description may still mention them. File presence does not establish adequacy._ Assessed commit `ac2d1400646e366a3a79ae14b2d19b36d2d3d712`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
