linslee75 commented on PR #5305: URL: https://github.com/apache/solr/pull/5305#issuecomment-6717472864
> [@linslee75](https://github.com/linslee75), I’ve prepared the sibling fixes and tests on top of your current PR head. You’re welcome to take them into this PR: > > [View the additional changes](https://github.com/nick-boss-tech/solr/compare/00292cd3729126194235e939afe38e351d850c70...219fee78bf7cae5039e50fe885108a1d4937ccd3) > > From your PR branch, you can bring in the commit with: > > ``` > git switch SOLR-18627-ignored-field-npe > git fetch https://github.com/nick-boss-tech/solr.git pr-5305-solr-18627-ignored-fields > git merge --ff-only 219fee78bf7cae5039e50fe885108a1d4937ccd3 > ``` > > The added tests cover ignored fields and preserve docValues-only behavior. One question about the changes that delegate to super.createFields(). Before Solr 10.1, these field types had their own createFields() implementations, including the DocValues handling. Since your changes move some of this logic to the parent implementation, do you think we need focused tests to verify that the existing behavior is preserved, particularly for DocValues and multi-valued fields? I just want to make sure this change does not introduce unintended behavior differences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
