dsmiley commented on PR #5308: URL: https://github.com/apache/solr/pull/5308#issuecomment-6695601839
🤖 Example of the new format: a real run with `qwen3.8-27b` on the merged PR #5026, which has two mismatches (the changelog type, and a tests row that is a false positive because the test lives in `AbstractInstallShardTest`, outside the test globs). --- **Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). Consider enabling [Allow edits from maintainers](https://docs.github.com/en/pull-requests/how-tos/work-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) so Solr maintainers can contribute to this branch (optional). **2 possible mismatch(es)** between what this change warrants and what the PR includes. - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ⚠️ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) **— differs from the entry** (suggest type: fixed; PR has type: changed): The change fixes a user-visible issue where INSTALLSHARD operations would log noise or fail gracefully due to the presence of 'write.lock' files in offline index directories, which is a common scenario for users copying live indices. - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not needed <!-- This is an internal robustness fix that handles a specific file type gracefully; it does not introduce new configuration, parameters, or user-facing behaviors that require documentation in the Reference Guide. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is additive and backward-compatible, simply skipping a file that was previously causing issues, without removing or renaming any APIs or configuration. --> - ⚠️ Tests **— missing**: The PR modifies production logic in RestoreCore.java to skip write.lock files, and the diff includes new tests in AbstractInstallShardTest.java to verify this behavior. <!-- Assessed commit f220b849b9008f46a5c659703f58e08cae13b0b3 --> --- <details> <summary>Markdown source</summary> ````markdown **Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). Consider enabling [Allow edits from maintainers](https://docs.github.com/en/pull-requests/how-tos/work-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) so Solr maintainers can contribute to this branch (optional). **2 possible mismatch(es)** between what this change warrants and what the PR includes. - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ⚠️ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) **— differs from the entry** (suggest type: fixed; PR has type: changed): The change fixes a user-visible issue where INSTALLSHARD operations would log noise or fail gracefully due to the presence of 'write.lock' files in offline index directories, which is a common scenario for users copying live indices. - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not needed <!-- This is an internal robustness fix that handles a specific file type gracefully; it does not introduce new configuration, parameters, or user-facing behaviors that require documentation in the Reference Guide. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is additive and backward-compatible, simply skipping a file that was previously causing issues, without removing or renaming any APIs or configuration. --> - ⚠️ Tests **— missing**: The PR modifies production logic in RestoreCore.java to skip write.lock files, and the diff includes new tests in AbstractInstallShardTest.java to verify this behavior. <!-- Assessed commit f220b849b9008f46a5c659703f58e08cae13b0b3 --> ```` </details> 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
