sarkaramrit1993 opened a new pull request, #5307:
URL: https://github.com/apache/solr/pull/5307

   [SOLR-18629](https://issues.apache.org/jira/browse/SOLR-18629)
   
   # Description
   
   With `solr.log.cputime=true`, a distributed search reports the shards' CPU 
time in `cpuTime`. When a query limit (`timeAllowed`, `cpuAllowed`, 
`memAllowed`) stops the coordinator after some shards have answered, 
`SearchHandler.processComponentsDistrib` returns early and the shard CPU is 
never added. `cpuTime` then holds only the coordinator's own CPU, so partial 
results look much cheaper than they were.
   
   # Solution
   
   - Add shard CPU as each shard request finishes, instead of after the stage.
   - On each early return, publish what was collected so far if at least one 
shard request finished.
   
   # Tests
   
   `ShardCpuTimeLimitTest`: shards report a fixed 1000 ms, and a query limit 
stops the coordinator at each early return and after the GET_FIELDS round. Four 
of its five tests fail on main.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to