janhoy commented on PR #887: URL: https://github.com/apache/solr-operator/pull/887#issuecomment-6686986690
This is the output when run locally against #843 today: **3 possible mismatch(es)** between what this change warrants and what the PR includes. | | Warranted? | In PR? | Confidence | Why | |---|---|---|---|---| | ⚠️ [Changelog entry (solr-operator chart)](https://github.com/apache/solr-operator/blob/main/helm/solr-operator/Chart.yaml) **— missing** | added | no entry | high | The PR introduces a new opt-in external addressability method `Gateway` via a new CRD field `spec.solrAddressability.external.gateway` and a new enum value, which is a new capability users must enable. | | ✅ [Helm chart README values table](https://github.com/apache/solr-operator/blob/main/helm/solr-operator/README.md#chart-values) | no | no | high | The changes add RBAC rules and CRD fields but do not add, rename, or change any Helm chart values in `helm/solr-operator` or `helm/solr`. | | ✅ [Documentation (docs/modules)](https://github.com/apache/solr-operator/tree/main/docs/modules) | yes | yes | high | New CRD fields (`gateway`, `backendTLSPolicy`, etc.) and a new addressability method are added, which require documentation in `docs/modules` (e.g., `solr-cloud-crd.adoc`). | | ⚠️ [Upgrade notes](https://github.com/apache/solr-operator/blob/main/docs/modules/upgrade-notes/pages/upgrade-notes.adoc) **— missing** | yes | no | high | The operator requires new RBAC permissions for `gateway.networking.k8s.io` resources (`httproutes`, `backendtlspolicies`), which users managing RBAC manually must add, and the dependency upgrade to Gateway API v1.4+ may require installing new CRDs. | | ✅ [Tests](https://github.com/apache/solr-operator/blob/main/docs/modules/development/pages/development.adoc#testing) | yes | yes | high | Significant new Go logic is added in `controllers/solr_gateway_util.go` and `controllers/util/gateway_util.go` for reconciling HTTPRoutes and BackendTLSPolicies, which warrants unit tests in `controllers/*_test.go`. | | ✅ [New CRD option complete](https://github.com/apache/solr-operator/blob/main/docs/modules/solr-cloud/pages/solr-cloud-crd.adoc) | no | — | medium | The new API fields are wired through to the controllers, have appropriate doc comments and kubebuilder markers, and use pointers for optional fields where needed to distinguish unset from zero values. | | ⚠️ [Solr / Kubernetes version compatibility](https://github.com/apache/solr-operator/blob/main/docs/modules/upgrade-notes/pages/upgrade-notes.adoc#version-compatibility-matrixes) **— please check** | yes | — | high | The change depends on Gateway API v1.4.0+ for `BackendTLSPolicy` GA support, which is not available in the base Kubernetes 1.22 support range without additional CRD installation, and the PR description notes Kubernetes 1.23+ is required for Gateway API CRDs. | | ✅ Manual testing described | no | — | high | The PR description explicitly states that e2e tests were added and manual testing was performed with kgateway on Kubernetes 1.32, verifying backward compatibility and TLS backend connections. | _⚠️ mismatch, ❔ uncertain or unanswered, ✅ agrees. Matching changelog, docs and test files were hidden from the model; the PR description may still mention them. File presence does not establish adequacy._ Assessed commit `8e05fd973b5721fa9dbafaae1ba9f1afbb8ee5bf`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
