jaykay12 commented on code in PR #4178:
URL: https://github.com/apache/solr/pull/4178#discussion_r4416919133
##########
solr/core/src/java/org/apache/solr/cli/packagemanager/PackageManager.java:
##########
@@ -1079,9 +1062,8 @@ public void undeploy(
solrClient,
PackageUtils.getCollectionParamsPath(collection),
"{set: {PKG_VERSIONS: {" + packageName + ": null}}}");
- SolrCLI.postJsonToSolr(
- solrClient, PackageUtils.PACKAGE_PATH, "{\"refresh\": \"" +
packageName + "\"}");
- } catch (Exception ex) {
+ new PackageApi.RefreshPackage(packageName).process(solrClient);
+ } catch (Exception ex) { // postJsonToSolr above declares a plain throws
Exception
Review Comment:
this code comment still valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
