gerlowskija commented on PR #5211: URL: https://github.com/apache/solr/pull/5211#issuecomment-6418455400
> Would a test-only change like this be useful here, or would you rather keep the test as it is? Thanks @nick-boss-tech . I wasn't too worried about that case originally. The main indicator of `checkForExistingEphemeralNode`s success or failure is the exception thrown from that method if the nodes still exist at the end of the wait. But it's a nice little test hardening nonetheless. I've created a PR from your branch to bring the changes into this PR and merged it, thanks for the contribution! (https://github.com/gerlowskija/solr/pull/6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
