dsmiley commented on PR #5126: URL: https://github.com/apache/solr/pull/5126#issuecomment-6393523710
> Implicit highlighting includes ranking-only query terms. Without hl.q, the transformer uses the full search query, including eDisMax bq clauses. Explicit hl.q and the existing highlight component use the parser’s highlight query, which excludes those clauses. [Affected code](https://github.com/apache/solr/blob/74b09fb443f060caac3f8ec9701909cec276cfb4/solr/core/src/java/org/apache/solr/response/transform/HighlightAugmenterFactory.java#L178-L185) I don't think that's the case. The 'q' should be parsed by the parseHighlightQuery here which calls getHighlightQuery on the qparser and thus wouldn't have bq clauses. > Also, the body’s RTG support claim is stale: the latest ticket explicitly acknowledges RTG as unsupported. I'm not sure what "the body's RTG support claim" refers to. Body of the PR? I don't see an RTG reference there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
