nick-boss-tech commented on PR #5166: URL: https://github.com/apache/solr/pull/5166#issuecomment-6390266875
**Draft Review:** The Antora upgrade correctly updates both the CLI and site generator, and its linked-worktree support matches the stated motivation. Two readiness items remain: - Official multi-version site build: still unverified, including older Solr branches and Operator documentation. The author already acknowledges this. - Changelog check: currently fails. A changelog entry or maintainer-approved exemption would resolve it. One useful discovery: the [successful precommit log](https://github.com/apache/solr/actions/runs/38829063803) confirms that buildLocalAntoraSite and checkSiteLinks passed from a normal checkout. That closes one validation item still listed in the body. The YAML concern can also be narrowed: Antora changed CLI attribute/key coercion; its documentation still supports ordinary quoted YAML values. I found no affected Solr override. [Antora CLI documentation](https://docs.antora.org/antora/latest/cli/options/) AI-generated static review. Thanks for the upgrade! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
