nick-boss-tech commented on PR #5185: URL: https://github.com/apache/solr/pull/5185#issuecomment-6389926992
**Quick Review:** The JFR selector behaves as intended in the pinned OpenTelemetry version: it preserves the existing experimental metrics and suppresses the duplicate JMX CPU source. P3 readiness issue: the changelog entry is missing, and the current-head validator fails for that reason. A short SOLR-18544 bug-fix entry should cover the operator-visible metric recovery. Precommit and Crave tests are green. The older-JDK fix remains author-reported; the existing placement assertion checks metric presence, which alone does not prove that JFR samples update its value. AI-generated static review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
