nick-boss-tech opened a new pull request, #5215: URL: https://github.com/apache/solr/pull/5215
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-18458 ## What happens today **The legacy `debugQuery=true` parameter still enables debug output alongside the `debug` parameter that replaced it.** The ticket asks to drop `debugQuery` in lieu of `debug=all`. At the base, [CommonParams](https://github.com/apache/solr/blob/c8ab71430f6e7547c773da596101d680862310ff/solr/solrj/src/java/org/apache/solr/common/params/CommonParams.java) still defines it and the debug component still honors it, and a rerank fallback treats `debug=results` as a debug request even without a response builder asking for one. ## What this change does **`debugQuery` is removed; `debug` is the only switch.** The constant and its handling are gone from [CommonParams](https://github.com/apache/solr/blob/ada3b8805d4e514be2bd398ef1e462d9567391f8/solr/solrj/src/java/org/apache/solr/common/params/CommonParams.java) and [DebugComponent](https://github.com/apache/solr/blob/ada3b8805d4e514be2bd398ef1e462d9567391f8/solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java), SolrJ and the Admin UI no longer send or offer it, and the Ref Guide pages that documented it now document `debug` only. The rerank fallback now keys on `debug=all` and `debug=true`, not `debug=results`. Tests that used `debugQuery` are migrated to the `debug` parameter, and a new test pins that the legacy parameter is ignored. ## Proof **The new coverage fails without the change and passes with it, and the touched modules check clean.** Verified at the gated tree (this head is a squash of that tree, byte-identical): - The legacy-parameter test fails against the base code and passes at the head: [DebugComponentTest.testLegacyDebugQueryParameterIgnored](https://github.com/apache/solr/blob/ada3b8805d4e514be2bd398ef1e462d9567391f8/solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java#L68). - Focused runs at seed `18458C0FFEE18458`: core 290 tests, SolrJ 2 tests, LTR 91 tests, language-models 23 tests, no failures; the rerank tests run 14 with no failures, including the new `debug=all` fallback test. - Tidy is clean, Error Prone compilation passes, and `check -x test` passes on `:solr:core`, `:solr:solrj`, `:solr:modules:ltr`, and `:solr:modules:language-models`. ## Limits - The parameter is dropped outright rather than deprecated first. The ticket floats a DeprecationLog warning for 10.x as an option; this change targets the next major release and removes the parameter there. - A request that still passes `debugQuery=true` now gets no debug output and no warning. That silence is inherited from how unknown parameters behave generally in Solr. ## Checklist - [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. SOLR-18458 - [x] I have given Solr maintainers access to contribute to my PR branch. - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. **Not run in full:** the module checks listed under Proof pass at the head. - [x] I have added tests for my changes. - [x] I have added documentation for the Reference Guide. - [x] I have added a changelog entry. *AI-generated description. Nick Shanin directed the work and takes responsibility for this contribution.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
