janhoy commented on code in PR #5049:
URL: https://github.com/apache/solr/pull/5049#discussion_r4335404339


##########
solr/solr-ref-guide/modules/deployment-guide/pages/solrcloud-distributed-requests.adoc:
##########


Review Comment:
   Not too worried as a ref-guide version only ever links to javadocs for the 
same solr version. So if we want another structure than the all-in-one flat one 
in the future, that will be for that version and not change what was released 
in earlier versions.
   
   Are you concerned that the (relative) URL of a certain Class javadoc 
changes, so that you cannot easily jump between versions by just changing the 
version component in the URL, e.g.
   
   E.g. 
https://solr.apache.org/docs/10_0_0/core/org/apache/solr/cluster/Node.html 
becomes 
https://solr.apache.org/docs/10_2_0/javadocs/api/org/apache/solr/cluster/Node.html
 - so if you have the 10.2 URL and want to look at the 10.0 version, you'd need 
to know it is in core module and the old URL layout. Not sure if we can do any 
back-compat magic here. 
   
   I see your idea of preserving the module in the antora links by introducing 
a template var per module, and then point all of them at `javadocs/api`, while 
we later could redirect each to module specific path again...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to