syahra712 commented on PR #137: URL: https://github.com/apache/solr-orbit/pull/137#issuecomment-6290384882
Good question. It's a gap in the port rather than a new design. `SolrCollectionStats` (like the other `Solr*Stats` devices) was written for Solr in the initial port (57387ed4) and has no OpenSearch Benchmark counterpart. So there's no upstream wiring to copy for this device. The closest upstream pattern is OSB's `NodeStats`/`ShardStats`: they receive `telemetry_params`, read `<device>-sample-interval` themselves, and raise `SystemSetupError` for values <= 0. In solr-orbit, the ported `ShardStats` still works that way. The always-on Solr devices are built in `_create_solr_telemetry_devices` without the params, which is why the documented `collection-stats-sample-interval` was never read. This PR copies the upstream validation but passes the value at the call site. If you'd rather match OSB exactly, I can pass `telemetry_params` into `SolrCollectionStats.__init__` and read it there, as `ShardStats` does. Just say which you prefer. I also merged main to fix the conflict with the `ClusterEnvironmentInfo` test (both tests kept). The full `tests/` suite passes: 1177 passed, 5 skipped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
