epugh commented on PR #5175: URL: https://github.com/apache/solr/pull/5175#issuecomment-6291600280
Also pluralized \`requestHandler\` -> \`requestHandlers\` in the full v2 \`/config\` response, for consistency with the dedicated \`GET /config/requestHandlers\` endpoint (which has used the plural form since the requestHandler migration) and with \`searchComponent\`/\`queryResponseWriter\` already being pluralized here. v1's \`/config\` is unaffected. Also caught and fixed two test assertions (\`TestSolrConfigHandler.testProperty\` and \`reqhandlertests\`) that checked the full \`/config\` response for a hardcoded singular \`"requestHandler"\` key without v1/v2 branching — these would have started failing intermittently against the randomized V2 harness runs once this landed, the same class of issue the existing \`searchComponentKey\` branching already guarded against. Reproduced the failure first (3-4/4 runs failing), then fixed and reran clean (4/4, 6/6 across separate runs). Updated the ref guide to describe this as a third V1/V2 difference in the full-config output, alongside the existing \`children\`-key and \`searchComponent\`/\`queryResponseWriter\` notes. CI re-approved and running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
