sarkaramrit1993 commented on PR #5127: URL: https://github.com/apache/solr/pull/5127#issuecomment-6196871804
Thanks @psalagnac, good catches. Reworked the test in the latest commit: - Goes through `ZkController` and `Overseer.getAsyncIdsMap()` now, no ZK paths or prefixes. - Overseer enabled: snapshots the completed, failure and claimed async ids before the rebalance, and checks nothing new is left after. - Overseer disabled: checks the command returns well before `maxWaitSeconds`, since the wait only ends early once every sub-command's stored response is removed. - Also asserts at least one leader change was requested, so it can't pass on a no-op. Distributed mode has no direct leak check, on purpose. There's no public way to list what the async tracker holds and the sub-command ids never reach the client, so a direct check means either ZK internals again or test-only production code. The removal goes through the same `ZkController.removeStoredAsyncResponse` as DELETESTATUS, which `DeleteStatusTest` already covers in that mode. Verified it fails against the original code in distributed mode, and against versions that skip removing or releasing the ids in Overseer mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
