epugh commented on PR #5120: URL: https://github.com/apache/solr/pull/5120#issuecomment-6149096884
I'd love another set of eyes. Here is what we had: <img width="799" height="465" alt="image" src="https://github.com/user-attachments/assets/d487319d-b444-45ab-ac87-c92f756d5079"; /> And after this change: <img width="833" height="468" alt="image" src="https://github.com/user-attachments/assets/44b3b00b-82b1-4d9e-94fd-6710e46de503"; /> We need to wrap certain urls that have `&` characters etc. But if we don't have that, should we still wrap them in single quotes? I like that we use single quotes everywhere, instead of a mix of single and double quote.. But maybe we don't want quotes on simpler URLs? WOuld love another opinion on what looks best! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
