[
https://issues.apache.org/jira/browse/SOLR-18502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126824#comment-18126824
]
Chris M. Hostetter commented on SOLR-18502:
-------------------------------------------
The addition of {{AbstractInstallShardTest.testInstallSkipsWriteLockFile}} is
causing 100% failure rate in the subclass {{S3InstallShardTest}} in all jenkins
runs -- and any seed i try locally...
{noformat}
2> 23752 INFO
(TEST-S3InstallShardTest.testInstallSkipsWriteLockFile-seed#[53934821DA27F998])
[n:127.0.0.1:35307_solr] o.a.s.SolrTestCaseJ4 ###Ending
testInstallSkipsWriteLockFile
> java.lang.AssertionError: Test data should include a write.lock
> at
__randomizedtesting.SeedInfo.seed([53934821DA27F998:8E92A1753F14A7C3]:0)
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at
org.apache.solr.cloud.api.collections.AbstractInstallShardTest.testInstallSkipsWriteLockFile(AbstractInstallShardTest.java:206)
> at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
...
1 test completed, 1 failed
> Task :solr:modules:s3-repository:test FAILED
ERROR: The following test(s) have failed:
- org.apache.solr.s3.S3InstallShardTest.testInstallSkipsWriteLockFile
(:solr:modules:s3-repository)
Test history:
https://develocity.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.s3.S3InstallShardTest&tests.test=testInstallSkipsWriteLockFile
http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.s3.S3InstallShardTest.testInstallSkipsWriteLockFile
Test output:
/home/hossman/lucene/solr/solr/modules/s3-repository/build/test-results/test/outputs/OUTPUT-org.apache.solr.s3.S3InstallShardTest.txt
Reproduce with: ./gradlew :solr:modules:s3-repository:test --tests
"org.apache.solr.s3.S3InstallShardTest.testInstallSkipsWriteLockFile"
"-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC
-XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=53934821DA27F998 -Ptests.useSecurityManager=false
-Ptests.file.encoding=US-ASCII
{noformat}
> INSTALLSHARD (and RESTORE) should skip write.lock when copying index files
> --------------------------------------------------------------------------
>
> Key: SOLR-18502
> URL: https://issues.apache.org/jira/browse/SOLR-18502
> Project: Solr
> Issue Type: Improvement
> Components: Backup/Restore
> Affects Versions: main(11.0), 9.10.1
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The offline indices that INSTALLSHARD copies into the shard leader probably
> shouldn't contain "write.lock" files, but they commonly do. This doesn't
> cause errors per se - INSTALLSHARD handles these files fine. But it can be a
> bit noisy logging wise, as Solr warns on these files as they don't have the
> checksum footer that Solr/Lucene expects of index files.
> It'd be an nice quality of life improvement if INSTALLSHARD was smart enough
> to skip over these files if they exist, rather than cluttering up the logs
> with false-positive "WARN" messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
