serhiy-bzhezytskyy opened a new pull request, #5121: URL: https://github.com/apache/solr/pull/5121
https://issues.apache.org/jira/browse/SOLR-18500 # Description Of 510 `curl` commands in the Ref Guide, the URL is single-quoted in 161, double-quoted in 89 and unquoted in 190. Eleven of the unquoted ones cannot be copied as written: the shell ends the URL at `&` or reads `<signature>` as a redirect. # Solution Every URL is single-quoted, except the 6 that need shell escapes or `$VAR` expansion. `-X GET` and `-XPOST` next to `-d` are dropped, and `-X POST` in the `-T` example moves before the URL. Written with Claude Code. # Tests For each of the 266 commands that only changed quotes, bash passes `curl` the same arguments before and after. The 11 unquoted ones now pass the whole URL. `buildLocalAntoraSite` and `checkSiteLinks` pass. # Checklist - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
