nick-boss-tech commented on PR #5065: URL: https://github.com/apache/solr/pull/5065#issuecomment-6139135892
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* Thanks for the fix. Two things we tested here, offered as options and not as a change request. First, a forced interleave test at the persistConf level: one edit is parked inside the serializer, and both users must survive as one JSON document. The 20-POST test catches the race only by chance. Second, writing the new contents to a temp file and then moving it into place, so a failed write keeps the old file. Your PR still truncates first, so a failure mid-write can leave a short file. We understand you chose not to do the rename here. I have put the version with both elements up as a draft in #5118 so you can see them worked out. Would you like either as a follow-up commit, or would you rather keep this change to the lock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
