Boyi Dai created SOLR-18538:
-------------------------------

             Summary: CREATESNAPSHOT reports success when a shard has no active 
replica
                 Key: SOLR-18538
                 URL: https://issues.apache.org/jira/browse/SOLR-18538
             Project: Solr
          Issue Type: Bug
          Components: Backup/Restore
    Affects Versions: 10.0
            Reporter: Boyi Dai


CreateSnapshotCmd skips replicas that are not ACTIVE and only evaluates 
failures for shards it sent a core snapshot request to. If every replica of a 
shard is inactive, that shard is never checked, and the collection snapshot is 
recorded as Successful with no core snapshot for it.

The same happens when a shard’s only active replica fails to create its 
snapshot, because the failure count is compared against all of the shard’s 
replicas, including the inactive ones that were skipped.

Since the snapshot name is then taken, retrying CREATESNAPSHOT with the same 
name is rejected, and the snapshot cannot be used for a backup of the missing 
shard.

Steps to reproduce:
 # Create a collection with one shard and one replica.
 # Stop the node hosting that replica so it becomes DOWN.
 # Run CREATESNAPSHOT for the collection.

Expected: the request fails and the snapshot is marked Failed.
Actual: the request succeeds and the snapshot is marked Successful with no core 
snapshots.

Expected behavior in general: the snapshot should fail unless every active 
shard has at least one replica with a core snapshot. A fix with a test is 
coming in a PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to