iprithv commented on code in PR #5110:
URL: https://github.com/apache/solr/pull/5110#discussion_r4252733741
##########
solr/webapp/web/index.html:
##########
@@ -167,98 +174,121 @@ <h2>Connection recovered...</h2>
<li id="login" class="global" ng-class="{active:page=='login'}"
ng-show="http401 || currentUser"><p><a href="#/login">{{http401 ? "Login" :
"Logout " + currentUser}}</a></p></li>
- <li id="index" class="global"
ng-class="{active:page=='index'}"><p><a href="#/">Dashboard</a></p></li>
-
<div ng-show="!http401">
- <li id="logging" class="global"
ng-class="{active:page=='logging'}"><p><a href="#/~logging">Logging</a></p>
- <ul ng-show="showingLogging">
- <li class="level"
ng-class="{active:page=='logging-levels'}"><a
href="#/~logging/level">Level</a></li>
+
+ <li class="menu-section" id="menu-section-cluster"
ng-show="isCloudEnabled">Cluster</li>
+
+ <li ng-show="isCloudEnabled" id="cloud-nodes" class="global"
ng-class="{active:page=='cloud-nodes'}"><p><a
href="#/~cloud?view=nodes">Nodes</a></p></li>
+ <li ng-show="isCloudEnabled" id="cloud-tree" class="global"
ng-class="{active:page=='cloud-tree'}"><p><a
href="#/~cloud?view=tree">Tree</a></p></li>
+ <li ng-show="isCloudEnabled" id="cloud-zkstatus" class="global"
ng-class="{active:page=='cloud-zkstatus'}"><p><a
href="#/~cloud?view=zkstatus">ZK Status</a></p></li>
+ <li ng-show="isCloudEnabled" id="cloud-graph" class="global"
ng-class="{active:page=='cloud-graph'}"><p><a
href="#/~cloud?view=graph">Graph</a></p></li>
+
+ <li ng-show="isCloudEnabled" id="security" class="global"
ng-class="{active:page=='security'}"><p><a
href="#/~security">Security</a></p></li>
+
+ <li ng-show="isCloudEnabled && isSchemaDesignerEnabled"
id="schema-designer" class="global"
ng-class="{active:page=='schema-designer'}"><p><a
href="#/~schema-designer">Schema Designer</a></p></li>
+
+ <li ng-show="isCloudEnabled" id="collections" class="global"
ng-class="{active:page=='collections'}"><p><a
href="#/~collections">Collections</a></p></li>
+
+ <div id="collection-selector" class="menu-control"
ng-show="isCloudEnabled">
+ <div id="has-collections" ng-show="collections.length!=0">
+ <select placeholder-text-single="'Collection Selector'"
+ ng-model="currentCollection"
+ chosen
+ search-contains="true"
+ ng-change="showCollection(currentCollection)"
+ ng-options="collection.name for collection in
aliases_and_collections"></select>
+ </div>
+ <p id="has-no-collections" ng-show="collections.length==0"><a
href="#/~collections">
+ No collections available
+ <span>Go and create one</span>
+ </a></p>
+ </div>
+ <div id="collection-menu" class="sub-menu"
ng-show="currentCollection">
+ <ul>
+ <li class="overview" ng-show="currentCollection.type ===
'collection'" ng-class="{active:page=='collection-overview'}"><a
href="#/{{currentCollection.name}}/collection-overview"><span>Overview</span></a></li>
+ <li class="overview" ng-show="currentCollection.type ===
'alias'" ng-class="{active:page=='alias-overview'}"><a
href="#/{{currentCollection.name}}/alias-overview"><span>Overview</span></a></li>
+ <li class="analysis"
ng-show="!isMultiDestAlias(currentCollection)"
ng-class="{active:page=='analysis'}"><a
href="#/{{currentCollection.name}}/analysis"><span>Analysis</span></a></li>
+ <li class="documents"
ng-show="!isMultiDestAlias(currentCollection)"
ng-class="{active:page=='documents'}"><a
href="#/{{currentCollection.name}}/documents"><span>Documents</span></a></li>
+ <li class="paramsets"
ng-show="!isMultiDestAlias(currentCollection)"
ng-class="{active:page=='paramsets'}"><a
href="#/{{currentCollection.name}}/paramsets"><span>Paramsets</span></a></li>
+ <li class="files"
ng-show="!isMultiDestAlias(currentCollection)"
ng-class="{active:page=='files'}"><a
href="#/{{currentCollection.name}}/files"><span>Files</span></a></li>
+ <li class="query" ng-class="{active:page=='query'}"><a
href="#/{{currentCollection.name}}/query"><span>Query</span></a></li>
+ <li class="stream" ng-class="{active:page=='stream'}"><a
href="#/{{currentCollection.name}}/stream"><span>Stream</span></a></li>
+ <li class="sqlquery" ng-class="{active:page=='sqlquery'}"><a
href="#/{{currentCollection.name}}/sqlquery"><span>SQL</span></a></li>
+ <li class="schema"
ng-show="!isMultiDestAlias(currentCollection)"
ng-class="{active:page=='schema'}"><a
href="#/{{currentCollection.name}}/schema"><span>Schema</span></a></li>
</ul>
+ </div>
+
+ <li class="menu-section" id="menu-section-node">Node</li>
+
+ <li id="node-selector-item" class="menu-control"
ng-show="isCloudEnabled && liveNodes.length > 1">
+ <div id="node-selector">
+ <label id="node-selector-label"
for="node-selector-select">Node</label>
+ <div id="has-nodes">
+ <select id="node-selector-select"
+ aria-labelledby="node-selector-label"
+ placeholder-text-single="'Select node'"
+ ng-model="selectedNode"
+ chosen
+ search-contains="true"
+ ng-change="onSelectedNodeChange()"
+ ng-options="node as nodeLabel(node) for node in
liveNodes"></select>
+ </div>
+ <p id="node-selector-hint" ng-class="{remote:
viewingRemoteNode}">
+ {{ viewingRemoteNode ? 'Remote node (Node screens only)' :
'This node — Node screens only' }}
Review Comment:
I'm not convinced with this either...any better messaging which would help
hre? @janhoy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
