janhoy commented on code in PR #5063: URL: https://github.com/apache/solr/pull/5063#discussion_r4224498232
########## solr/solr-ref-guide/modules/deployment-guide/pages/cli/solr-version.adoc: ########## @@ -33,8 +33,8 @@ See xref:cli/index.adoc[] to enable this implementation and for its known limita == Synopsis .... -bin/solr version [-hv] [-u=<credentials>] [-s=<solrConnection> | - --solr-url=<solrUrl> | -z=<zkHost>] +bin/solr version [-hv] [-s=<solrConnection>] [--solr-url=<solrUrl>] + [-u=<credentials>] [-z=<zkHost>] Review Comment: Here you can see the only visible side effect of this refactor. Since we don't use PicoCLI's `ArgGroup` anymore but a `@MixIn` instead we do not get the grouping of related options like in ``` [-s=<solrConnection> | --solr-url=<solrUrl> | -z=<zkHost>] ``` Instead all options are listed individually, and we enforce mutual exclusitivity in the mixin code. ``` [--solr-url=<solrUrl>] [-u=<credentials>] [-z=<zkHost>] ``` Personally I don't think that bother anyone. Not many normal CLi tools use the `[ foo | bar ]` syntax, it's kind of an advanced feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
