dsmiley commented on code in PR #5018:
URL: https://github.com/apache/solr/pull/5018#discussion_r4175027340
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -393,15 +390,6 @@ private static Set<String> findClasses(String path, String
packageName) throws E
return classes;
}
- private static final String JSON_CONTENT_TYPE = "application/json";
-
- public static NamedList<Object> postJsonToSolr(
Review Comment:
IMO this should stay put. It's used by a variety of things (apparently);
isn't specific to the "package manager".
It's only a few lines of code; straight-forward stuff. If the package
manager wants to do this too, it can either have its own copy or just inline
the callers in solr core.
##########
solr/test-framework/build.gradle:
##########
Review Comment:
nice
##########
solr/core/src/java/org/apache/solr/packagemanager/UserIO.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.packagemanager;
+
+/** Console-facing output for package manager operations */
+@FunctionalInterface
+public interface UserIO {
Review Comment:
ToolRuntime (in CLI) implements this, i see. What implements this within
solr core?
##########
solr/core/src/test/org/apache/solr/cli/SolrCloudExampleTest.java:
##########
Review Comment:
nice change
##########
solr/core/src/java/org/apache/solr/packagemanager/UserIO.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.packagemanager;
+
+/** Console-facing output for package manager operations */
+@FunctionalInterface
+public interface UserIO {
+
+ UserIO NONE = message -> {};
+
+ void print(String message);
+
+ default void printSuccess(String message) {
+ print(PackageUtils.GREEN + message + PackageUtils.RESET +
System.lineSeparator());
Review Comment:
Perhaps the colors are better defined on this interface instead of
PackageUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
