nick-boss-tech opened a new pull request, #5015: URL: https://github.com/apache/solr/pull/5015
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-13706 `PluginInfo` grouped a plugin's children by name when serializing, but children are looked up by type (`getChildren(type)`), and unrelated plugin types can share a name: the highlight component's formatter and encoder are both named "html", so one of them overwrote the other in the serialized output. `SolrConfig` also carried a workaround, with a TODO pointing at this ticket, that skipped the "highlight" searchComponent in the config dump entirely. The fix groups children by type instead of name; the name is preserved inside each child's own serialized attributes. The `SolrConfig` workaround is removed, so the "highlight" searchComponent output is no longer dropped. Compatibility note: the serialized child grouping is now keyed by type rather than by name. That matches how the children are consumed through `getChildren(type)`, but it is a visible change to the Config API output shape, related to the config serialization discussion on SOLR-14795. `PluginInfoTest` gains a serialization test with children grouped by type, including two children of different types that share a name. Validation on the final tree: Error Prone compile clean, `PluginInfoTest` passes, `tidy` applied with no changes, `:solr:core:check -x test` green. Changelog: `changelog/unreleased/SOLR-13706.yml` (type fixed). ### AI assistance AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
