nick-boss-tech opened a new pull request, #5013: URL: https://github.com/apache/solr/pull/5013
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-13524 `RecursiveBooleanEvaluator.doWork` reduced its values with a pairwise loop that returns false as soon as one adjacent pair fails its check. That is only correct for conjunctive (AND style) checkers: for `or()` with more than two arguments, a sequence such as (true, false, true) failed on the first pair and wrongly returned false. This change extracts the shared validation into `validateValues(...)` in the base class and gives `OrEvaluator` its own `doWork` that returns true as soon as any value is true. `OrEvaluatorTest` gains a regression test for `or()` with more than two arguments. Validation on the final tree: Error Prone compile clean, `OrEvaluatorTest` passes, `tidy` applied with no changes, `:solr:solrj-streaming:check -x test` green. Changelog: `changelog/unreleased/SOLR-13524.yml` (type fixed). ### AI assistance AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
