nick-boss-tech opened a new pull request, #5011: URL: https://github.com/apache/solr/pull/5011
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-12849 Collection aliases were resolved differently depending on where the `collection` parameter arrived. `HttpSolrCall.addCollectionParamIfNeeded` read only the URL query parameters, so a request carrying `collection=<alias>` in a POST form body did not get the same alias resolution as the identical GET. The fix reads the merged parameter set (`getQueryParams()`, which combines URL and body parameters) when deciding whether the collection parameter still needs resolving. The new `AliasPostBodyTest` covers the ticket scenario end to end on a one node cluster: create a collection and an alias, then POST to `/<alias>/select` with `collection=<alias>` in the form body and assert the request succeeds instead of failing to find the collection. The suite is annotated `@SuppressSSL` because the raw `HttpURLConnection` it uses cannot validate the randomized test certificate; the scenario is unrelated to TLS. The gate caught the test failing with a TLS error under a seed that randomizes SSL on, and this branch fixes that. Validation on the final tree: Error Prone compile clean, `AliasPostBodyTest` passes (including locked to a seed that randomizes SSL on), `tidy` applied, `:solr:core:check -x test` green. Changelog: `changelog/unreleased/SOLR-12849.yml` (type fixed). ### AI assistance AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
