jaykay12 commented on code in PR #4951: URL: https://github.com/apache/solr/pull/4951#discussion_r4169343422
########## changelog/unreleased/SOLR-16396-config-get.yml: ########## @@ -0,0 +1,14 @@ +title: + Migration of Get Config V2 API to JAX-RS construct. Note one response-shape difference from V1 - + a plugin's unnamed child elements (e.g. anonymous `processor` entries under an + `updateRequestProcessorChain`) are now grouped under a `children` key in the V2 JSON response, + instead of V1's legacy empty-string (`""`) key. Review Comment: Title looks little too verbose to me, do we by convention writes such big titles in the CL? [not sure if it exists or not] should there be another key in the CL yml file say description to capture such low level details? comment is minor from my side, please take the call as per our community guidelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
