nick-boss-tech opened a new pull request, #4995: URL: https://github.com/apache/solr/pull/4995
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-18196 SOLR-18196 reported Java serialization broken for `QueryResponse` (`SimpleOrderedMap implements Map` breaks `ObjectOutputStream`). This adds regression coverage proving the round trip works on current main — no production code change was needed: - `SimpleOrderedMapTest.testJavaSerializationRoundTrip`: serializes/deserializes a map with mixed value types (String, int, null value, null key, nested map, list) and asserts equality. - `QueryResponseTest.testQueryResponseSerialization`: parses `solrj/sampleDebugResponse.xml`, wraps it in a `QueryResponse`, round-trips it through Java serialization, and asserts results, `numFound`, and the explain map survive. Both use `@SuppressForbidden` for the same-version, locally-generated-data serialization, following the existing `SolrQueryTest` precedent. Test-only change, so no changelog entry. Tests: `QueryResponseTest` + `SimpleOrderedMapTest` — 24 tests green with Error Prone. ### AI assistance AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
