dsmiley commented on code in PR #4672:
URL: https://github.com/apache/solr/pull/4672#discussion_r4116533723
##########
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##########
Review Comment:
The "vision" isn't anything more involved than what I said. Instead of
adding this method here, put it in SolrJ; maybe Utils, since the method isn't
even specific to configsets. It means losing the call to
`isFileForbiddenInConfigSets` but it's not up the the client to forbid
something; that's a server concern.
##########
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##########
@@ -314,6 +272,17 @@ protected void createCollection(CloudSolrClient
cloudSolrClient, CommandLine cli
echo(endMessage);
}
+ /**
+ * Zips the contents of a configset directory for upload.
+ *
+ * <p>Delegates to {@link ConfigSetService#zipDirectory}, which is shared
with {@link
Review Comment:
too much detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
