[
https://issues.apache.org/jira/browse/SOLR-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18119673#comment-18119673
]
Mikhail Khludnev commented on SOLR-18175:
-----------------------------------------
at the first glance here
https://github.com/apache/solr/blob/218ce981ba9404664aab1d2f1239ebdd33c980a4/solr/core/src/test/org/apache/solr/search/TestSolrQueryParser.java#L1736
we need to close {{req}} explicitly since assertQ() doesn't it for us.
and PeerSyncTest is more upsetting. If it read it write request/searcher leaks
from deleteByQuery but I can't imagine if UpdateHandler refuse to close a
request.
It makes me scared, don't even spend tokens on it. @dsmiley please consider
reverting https://gitbox.apache.org/repos/asf?p=solr.git;h=cb93d2d9d3a
> A FieldExistsQuery IllegalStateException should result in HTTP 400 not 500
> error
> --------------------------------------------------------------------------------
>
> Key: SOLR-18175
> URL: https://issues.apache.org/jira/browse/SOLR-18175
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> If you issue an existence query {{field:*}} yet that field does not support
> Lucene's {{FieldExistsQuery}}, FEQ.rewrite will throw IllegalStateException:
> bq. FieldExistsQuery requires that the field indexes doc values, norms or
> vectors, but field 'foo' exists and indexes neither of these data structures
> Solr ultimately returns a HTTP 500, which is not what we want. We want HTTP
> 400. Note that I discovered this via a {{facet.query}} and have yet to check
> if it were to happen simply in a {{q}}. The change likely involves modifying
> Solr {{FieldType.getExistenceQuery}} to throw an exception with the 400 code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
