epugh commented on code in PR #4946: URL: https://github.com/apache/solr/pull/4946#discussion_r4109320976
########## solr/core/src/java/org/apache/solr/jersey/MediaTypeOverridingFilter.java: ########## @@ -32,12 +30,14 @@ import java.util.List; import org.apache.solr.api.JerseyResource; import org.apache.solr.handler.admin.ZookeeperRead; -import org.apache.solr.handler.api.V2ApiUtils; -import org.apache.solr.request.SolrQueryRequest; -// TODO Deprecate or remove support for the 'wt' parameter in the v2 APIs in favor of the more -// HTTP-compliant 'Accept' header -/** Overrides the content-type of the response based on an optional user-provided 'wt' parameter */ +/** + * Defaults the response content-type to JSON, unless the client requested something else via the + * (HTTP-compliant) 'Accept' header. + * + * <p>v2 APIs do not honor the legacy 'wt' parameter for response-format selection -- 'Accept' is Review Comment: maybe still useful comment till we eliminate v1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
