janhoy commented on code in PR #4942:
URL: https://github.com/apache/solr/pull/4942#discussion_r4104125507


##########
solr/solr-ref-guide/modules/indexing-guide/pages/schema-api.adoc:
##########
@@ -523,11 +524,13 @@ V2 API::
 ====
 [source,bash]
 ----
-curl -X POST -H 'Content-type:application/json' --data-binary '{
-  "add-copy-field":{
-     "source":"shelf",
-     "dest":[ "location", "catchall" ]}
-}' http://localhost:8983/api/collections/techproducts/schema
+curl -X POST -H 'Content-type:application/json' --data-binary '[
+  {
+    "operationType":"add-copy-field",
+    "source":"shelf",
+    "destinations":[ "location", "catchall" ]

Review Comment:
   V1 uses `dest`, and the GET endpoint listing all copyfield rules will return 
json objects with `dest` keys. Thus it would be nice if the request and 
response shapes use same keys.
   
   Some of this may be thrown in the air by #4943 eventually, this PR is more 
to fix erraneous docs on the current main branch as it sits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to