epugh commented on code in PR #4941:
URL: https://github.com/apache/solr/pull/4941#discussion_r4087852988
##########
dev-docs/changelog.adoc:
##########
@@ -127,7 +127,23 @@ The `validate-changelog` GitHub workflow automatically
checks that:
. **CHANGES.txt is not edited directly** - All changes must use the YAML
fragment approach
. **A changelog entry is added** - Code changes must include a corresponding
YAML file in `changelog/unreleased/`
-If your change does not require a changelog entry, it is still possible to
merge the PR.
+Pull requests that only touch documentation, tests, build files or CI
configuration
+are exempt and pass without an entry.
+
+=== 4.1 Opting out of the changelog requirement
+
+If your change does not require a changelog entry (refactoring, internal
cleanup,
+and so on), it is still possible to merge the PR. Mark it by carrying the
Review Comment:
```suggestion
and so on), it is still possible to merge the PR. Mark it by adding the
```
##########
.github/workflows/changelog-comment-command.yml:
##########
@@ -0,0 +1,153 @@
+name: Changelog Comment Commands
+
+# Lets a PR author (or any committer) toggle the 'no-changelog' label by
+# commenting on the PR, without needing the repo write access that setting a
+# label directly requires:
+#
+# /no-changelog - mark the PR as not needing a changelog entry
+# /needs-changelog - undo that
+#
+# The command applies/removes the label, and the label change re-triggers the
+# "Validate Changelog" workflow (which listens for labeled/unlabeled events),
+# so the red check turns green on its own.
+#
+# This workflow deliberately never checks out or executes PR code: it only
+# reads the comment payload and calls the labels API, so running with a
+# write-scoped token is safe.
+on:
+ issue_comment:
+ types:
+ - created
+
+concurrency:
+ group: changelog-comment-command-${{ github.event.issue.number }}
+
+permissions:
+ issues: write # add/remove labels, add a reaction, post a reply
+ pull-requests: write
+
+jobs:
+ handle-command:
Review Comment:
OMG i hate the complexity and in ablity to write tests that GHA fosters...
But needs must when the devil drives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
