dsmiley commented on code in PR #4933:
URL: https://github.com/apache/solr/pull/4933#discussion_r4075202198
##########
dev-docs/distributed-update-internals.adoc:
##########
Review Comment:
I'll probably drop this as I don't want security matters distracting the
overall doc
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc:
##########
@@ -94,6 +94,9 @@ Users upgrading from 10.0 who relied on the pass-through
behavior must explicitl
PKI Authentication v1 support has been removed.
Solr 10.1 nodes only send and accept the `SolrAuthV2` (v2) header for
inter-node communication.
+`ExecutorUtil.isSolrServerThread()` now tracks work that originated from Solr
node startup or request handling (and work spawned from those), instead of any
task running on an MDC-aware pool.
Review Comment:
Hmm; not sure if worth a note here
##########
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##########
@@ -178,7 +179,13 @@ private void init(ServletContext servletContext) {
}
});
- coresInit = createCoreContainer(computeSolrHome(servletContext),
extraProperties);
+ Boolean previousServerThreadFlag = ExecutorUtil.isSolrServerThread() ?
Boolean.TRUE : null;
Review Comment:
maybe overkill to capture the prior state... prior state _should_ be blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
