dsmiley commented on code in PR #4695:
URL: https://github.com/apache/solr/pull/4695#discussion_r3992042233
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -188,6 +188,39 @@ public class RunExampleTool extends ToolBase {
protected String urlScheme;
private boolean usingPromptInputs = false;
+ /**
+ * Parameters consumed when starting a single Solr node via the bin/solr
script, common to all
+ * example modes.
+ *
+ * @param extraArgs extra arguments to pass on to the {@code bin/solr start}
command
+ */
+ record StartSolrParams(
+ String example,
+ String host,
+ String memory,
+ String jvmOpts,
+ boolean force,
+ String credentials,
+ String extraArgs) {}
+
+ /**
+ * Parameters for running a single-node example (techproducts, schemaless or
films), independent
+ * of the command line parser.
+ *
+ * @param zkHost ZooKeeper connection string resolved from option or
sysprop, or null
+ */
+ record RunExampleParams(boolean userManaged, String zkHost, int port,
StartSolrParams start) {}
Review Comment:
I'd prefer isCloudMode to avoid the clumsy/debatable "user managed" term
that I hate. Note that it's only caller inverts it to get cloud mode!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
