dsmiley commented on code in PR #4640:
URL: https://github.com/apache/solr/pull/4640#discussion_r3985857998
##########
solr/solrj/src/java/org/apache/solr/client/solrj/response/ResponseNormalizer.java:
##########
Review Comment:
if "canonicalize" is the name choice we're going with on
JsonMapResponseParser, then I suppose this class here should be renamed to
ResponseCanonicalizer
##########
solr/solrj/src/java/org/apache/solr/client/solrj/response/json/JsonMapResponseParser.java:
##########
@@ -78,12 +103,13 @@ public Set<String> getContentTypes() {
*/
@Override
public SolrParams getAdditionalRequestParams() {
- return REQUEST_PARAMS;
+ return canonical ? REQUEST_PARAMS : null;
Review Comment:
renaming that constant to CANONICAL_PARAMS would be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
