[ 
https://issues.apache.org/jira/browse/SOLR-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18114058#comment-18114058
 ] 

ASF subversion and git services commented on SOLR-18362:
--------------------------------------------------------

Commit bdb16c9706cf1cc94fba701c7e81aa89c19fd7a0 in solr's branch 
refs/heads/main from Serhiy Bzhezytskyy
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=bdb16c9706c ]

SOLR-18362: replace org.apache.solr.spelling.Token with SpellCheckToken (#4812)

The spellchecker API no longer passes terms around as 
org.apache.solr.spelling.Token, which is removed. Custom plugins in the 
org.apache.solr.spelling package need updating: QueryConverter.convert(String) 
now returns a Lucene TokenStream rather than a Collection<Token>, 
SpellingOptions.tokens is a List<SpellCheckToken> rather than a 
Collection<Token>, and SpellingResult is keyed by the new immutable record 
SpellCheckToken wherever it previously took a Token. Behaviour of the shipped 
spellcheckers and of the /spell request handler is unchanged.

Co-authored-by: Eric Pugh <[email protected]>

> Remove org.apache.solr.spelling.Token
> -------------------------------------
>
>                 Key: SOLR-18362
>                 URL: https://issues.apache.org/jira/browse/SOLR-18362
>             Project: Solr
>          Issue Type: Sub-task
>          Components: contrib - LTR, ltr
>            Reporter: Eric Pugh
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> `org.apache.solr.spelling.Token` has been deprecated since 7.0 with a TODO 
> noting the spellchecker API should be refactored to use Lucene `TokenStream`s 
> properly instead of this hack. No direct drop-in replacement exists — removal 
> requires refactoring the spellchecker code that still constructs/consumes 
> this class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to