[
https://issues.apache.org/jira/browse/SOLR-18414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113380#comment-18113380
]
Andrzej Bialecki commented on SOLR-18414:
-----------------------------------------
The remaining 2 failures were easy to fix:
* {{TestRangeQuery.testRangeQueryWithFilterCache}} triggers a condition in
{{SolrIndexSearcher:1024}} that specifically uses {{get + put}} instead of
{{computeIfAbsent}} to avoid locking out the map key while the query results
are being computed, potentially with limit exceeded errors. Since the unit test
uses multiple threads then it makes sense that this result is computed multiple
times due to racing.
*
{{TestLTRQParserPlugin.ltr_expensiveFeatureRescoringAndPartialResultsNotTolerated_shouldRaiseException}}
(uhh, who comes up with these names!...) was a simple assertion error because
it expected an exact message from a single QueryLimit - but with the added
no-op limit there are now two so the message differed.
I created PR #4894 with the changes, I left the limits creation on for now to
see if the Crave build passes, I'll change it back to rarely() before merging.
> Randomize use of QueryLimits in all tests
> ------------------------------------------
>
> Key: SOLR-18414
> URL: https://issues.apache.org/jira/browse/SOLR-18414
> Project: Solr
> Issue Type: Task
> Reporter: Chris M. Hostetter
> Assignee: Andrzej Bialecki
> Priority: Major
> Labels: pull-request-available
> Attachments: SOLR-18414.patch, SOLR-18414_10.0.0_failures.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a suggesting Smiley made in SOLR-18156...
> {quote}Maybe our test randomization should sometimes {{rarely()}} use a super
> long {{timeAllowed}} to help exercise this.
> {quote}
> Since TestInjection already has an easy way to add a QueryLimit, this can be
> done fairly easily using a "dummy" impl
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
