dsmiley commented on code in PR #4873:
URL: https://github.com/apache/solr/pull/4873#discussion_r3940666770
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/IntersectStream.java:
##########
@@ -203,13 +212,14 @@ public Tuple read() throws IOException {
}
// We're not at the end, and they're not equal. We now need to decide
which we can
- // throw away. This is accomplished by checking which is less than the
other. The
- // one that is less (determined by the sort) can be tossed. The other
should
- // be pushed back and the loop continued. We don't have to worry about
an == 0
- // result because we already know tuples a and b are not equal. And
because eq
- // is derived from the sorts of both streamA and streamB we can rest
assured that
- // equality is not a possibility.
- int aComp = streamA.getStreamSort().compare(a, b);
+ // throw away. This is accomplished by checking which is less than the
other, using
+ // crossStreamComparator - a comparator built from eq's (possibly
different) left/right
+ // field names, since streamA's own sort comparator only knows streamA's
field and would
+ // read null off of b. The one that is less can be tossed. The other
should be pushed back
+ // and the loop continued. We don't have to worry about an == 0 result
because we already
+ // know tuples a and b are not equal.
+ eq.assertFieldsPresent(a, b);
Review Comment:
(same response)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
