janhoy commented on PR #78: URL: https://github.com/apache/solr-orbit/pull/78#issuecomment-5545598663
I'm a bit reluctant to so much code for a naming. I considered this while doing the port but left it. I view the converter tool as a bootstrap tool to get you started, and then it will be a starting point, but expect the developer to tune and tweak it until it is ok for Solr. So perhaps we can accept some minors like this? I don't doubt that the code works, have not reviewed in detail, just my first reaction given the patch size, 277 lines more code to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
