Copilot commented on code in PR #4819:
URL: https://github.com/apache/solr/pull/4819#discussion_r3935263792
##########
solr/webapp/web/js/angular/controllers/schema-designer.js:
##########
@@ -656,31 +695,37 @@ solrAdminApp.controller('SchemaDesignerController',
function ($scope, $timeout,
}
delete $scope.addErrors; // no errors!
- SchemaDesigner.post({
- configSet: $scope.currentSchema,
- schemaVersion: $scope.schemaVersion
- }, addData, function (data) {
- if (data.errors) {
- $scope.addErrors = data.errors[0].errorMessages;
- if (typeof $scope.addErrors === "string") {
- $scope.addErrors = [$scope.addErrors];
+ SchemaDesignerV2.addSchemaObject($scope.currentSchema, {
+ schemaVersion: $scope.schemaVersion,
+ schemaDesignerAddRequestBody: addData
Review Comment:
The generated-Java round-trip test does not cover this JavaScript request
path, and the Selenium test only exercises prep plus the legacy analyze call.
Since the original regression was specifically that generated JS clients
emitted `addField` instead of `add-field`, please add a browser/client test
that invokes this call and verifies an added field succeeds with the kebab-case
wire key; otherwise the reported regression can return without any test failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
