epugh commented on code in PR #4847:
URL: https://github.com/apache/solr/pull/4847#discussion_r3933406529
##########
solr/core/src/java/org/apache/solr/handler/component/StatsField.java:
##########
@@ -84,7 +84,7 @@ public enum Stat {
distinctValues(true),
countDistinct(false, distinctValues),
percentiles(true) {
- /** special for percentiles * */
+ /* special for percentiles */
Review Comment:
I am onboard with changing the defaults that we are applying to ErrorProne.
In some projects with these types of chekcers we just adopt "we'll follow what
they recommend' and just keep updating to keep abrest. Obviously most of the
rules in ErrorProne we don't follow and we just pick and choose. I can back
out the `NotJavadoc` rule.... I suspected you would have an opinion ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
