serhiy-bzhezytskyy opened a new issue, #75:
URL: https://github.com/apache/solr-orbit/issues/75
### Description
`--randomization-enabled` has no effect on a Solr workload. Every client
sends the
one query written in the workload's `operations/*.json`, for the whole run,
and the
log says randomization is on.
`QueryRandomizerWorkloadProcessor.extract_fields_and_paths` walks
`params["body"]["query"]`
as an object tree looking for a `range` key, and `set_range` writes the new
bounds back
into that object. That is the OpenSearch query DSL, where the query is a
nested object.
Solr's JSON DSL states the query as a *string*:
```json
{ "query": "total_amount:[5 TO 15}" }
```
so the walk reaches a leaf immediately and returns no fields. With no
fields, no standard
value source is called, `set_range` never runs, and `get_randomized_values`
returns the
body it was given.
### Reproduction
On `main` at f0883807, with the two shapes of the same nyc_taxis `range`
operation:
```
Solr JSON DSL -> []
OpenSearch query DSL -> [('total_amount', ['bool', 'filter', 'range'])]
```
and end to end:
```
get_randomized_values -> total_amount:[5 TO 15} # the value source
returned {"gte": 3, "lte": 7}
```
Meanwhile `loader.py:1205` logs
```
Query randomization is enabled, with repeat frequency = 0, n = 5000
```
### Effect
Every nyc_taxis operation that registers a standard value source is affected
— `range`,
`distance_amount_facet`, `date_histogram_facet`,
`date_histogram_calendar_interval`,
`date_histogram_fixed_interval`. A run made with `--randomization-enabled`
measures the
same five queries as a run made without it, so it reports a warmed,
single-query cache
where it is meant to report a spread. Nothing fails, and no output
distinguishes the two
runs.
It also means every defect in a workload's value sources is unreachable, and
so untested:
a value source is only ever called from this processor. In
`solr-orbit-workloads`
`nyc_taxis/workload.py` there are two, both latent today —
`random_money_values` passes a
float to `random.randrange`, which raises `TypeError` on every Python this
project
supports, and `date_source_without_hours` writes both bounds at `T00:00:00Z`
into a query
with an exclusive upper bound, so one draw in six matches no documents at
all. I will open
those separately against `solr-orbit-workloads`; they become reachable the
moment this is
fixed.
### Expected
A range term in a Solr query string should have its bounds substituted,
keeping the
brackets the query already states, so an exclusive bound stays exclusive —
the same way
the object path keeps whichever of `lt`/`lte` it found. A term that leaves a
bound open
(`total_amount:[5 TO *]`) should be left alone, since the object path does
not randomize a
one-sided range either.
### Version
`main` at f0883807.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
