dsmiley commented on PR #4871: URL: https://github.com/apache/solr/pull/4871#issuecomment-5533622884
Gonna merge Sunday if no feedback. One possible consideration is, should these defaults be augmented/merged with a call to explicitly set them. I don't think I care much either way... but a benefit to not doing that is that a user can explicitly insist no params go in the URL if they want. Granted I don't know why they would care. Only one place in Solr, Distributed URP, is this called, which is to set the update distribution params. Update requests don't use any of these default params, so whatever. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
